Set num_workers=0 in Chronos-2 test data loader
#365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult (0) By default, the `transformers` library sets the `num_workers` argument of the PyTorch DataLoader to `0`, ensuring out-of-the-box compatibility across different platforms.
Contributor
|
@IliasAarab did you run into any issues with windows? |
abdulfatir
approved these changes
Nov 5, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the DataLoader configuration in the predict method to use single-threaded data loading by setting num_workers=0 instead of num_workers=1.
Key Changes
- Changed the
num_workersparameter from 1 to 0 in the DataLoader initialization within thepredictmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abdulfatir
reviewed
Nov 5, 2025
abdulfatir
changed the title
num_workers argument with transformers default (0)num_workers=0 in Chronos-2 test data loader
Contributor
Author
@abdulfatir thanks for the quick merge. Yes, I ran into a few issues on Windows, especially during quick prototyping, like when running snippets in a notebook or VS Code interactive window without guarded execution (i.e., without a if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
transformerslibrary sets thenum_workersargument of the PyTorch DataLoader to0, ensuring out-of-the-box compatibility across different platforms.Issue #, if available:
Description of changes:
Set the DataLoader
num_workersargument to0to improve cross-platform compatibility, particularly on Windows systems where multiprocessing requires guarded execution.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.