Skip to content

Conversation

@cooktheryan
Copy link
Collaborator

No description provided.

Signed-off-by: Ryan Cook <rcook@redhat.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Code Review - UBI Migration for Claude Code Runner

Summary

This PR migrates the runner from python:3.11-slim to Red Hat UBI9 with Python 3.11. Good direction for OpenShift compatibility!

Critical Issues

1. Missing Git Installation
The original Dockerfile installed git explicitly, but the new version removes it. Git is REQUIRED for cloning repositories in AgenticSession CRs.

Impact: Runner will fail when cloning repos.
Solution: Add git via microdnf.

2. Missing Node.js/npm
The UBI9 Python image does NOT include Node.js or npm. The npm install command will fail.

Impact: Build fails.
Solution: Install nodejs and npm via microdnf.

Recommended Fix

Replace line 5 with:

# Install Node.js and git (required for claude-code CLI and repo operations)
RUN microdnf install -y nodejs npm git && microdnf clean all

RUN npm install -g @anthropic-ai/claude-code

Testing Needed

  1. Build test: Verify Dockerfile builds
  2. Runtime test: Check git --version, npm --version work in container
  3. Integration test: Run actual AgenticSession with repo cloning
  4. Multi-arch: Test ARM64 build

Strengths

  • Proper USER 0/1001 switching for OpenShift
  • Pinned digest for reproducibility
  • Cleaner Dockerfile structure
  • Correct permissions (chmod -R g=u)

Priority: HIGH - Build will fail without dependency installations.

@Gkrumbach07
Copy link
Collaborator

Tracked in Jira: https://issues.redhat.com/browse/RHOAIENG-39126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants