Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2025

Bumps actions/upload-artifact from 4 to 5.

Release notes

Sourced from actions/upload-artifact's releases.

v5.0.0

What's Changed

BREAKING CHANGE: this update supports Node v24.x. This is not a breaking change per-se but we're treating it as such.

New Contributors

Full Changelog: actions/upload-artifact@v4...v5.0.0

v4.6.2

What's Changed

New Contributors

Full Changelog: actions/upload-artifact@v4...v4.6.2

v4.6.1

What's Changed

Full Changelog: actions/upload-artifact@v4...v4.6.1

v4.6.0

What's Changed

Full Changelog: actions/upload-artifact@v4...v4.6.0

v4.5.0

What's Changed

New Contributors

... (truncated)

Commits
  • 330a01c Merge pull request #734 from actions/danwkennedy/prepare-5.0.0
  • 03f2824 Update github.dep.yml
  • 905a1ec Prepare v5.0.0
  • 2d9f9cd Merge pull request #725 from patrikpolyak/patch-1
  • 9687587 Merge branch 'main' into patch-1
  • 2848b2c Merge pull request #727 from danwkennedy/patch-1
  • 9b51177 Spell out the first use of GHES
  • cd231ca Update GHES guidance to include reference to Node 20 version
  • de65e23 Merge pull request #712 from actions/nebuk89-patch-1
  • 8747d8c Update README.md
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 11, 2025
@github-actions
Copy link
Contributor

Pull Request Review: Bump actions/upload-artifact from v4 to v5

Summary

This Dependabot PR upgrades actions/upload-artifact from v4 to v5 in the E2E test workflow. The changes are minimal and safe to merge.


✅ Code Quality & Best Practices

  • Clean change: Only affects artifact upload steps in .github/workflows/e2e.yml
  • Consistent usage: Both artifact upload steps (screenshots and videos) are updated uniformly
  • Conditional execution: Properly uses if: failure() to only upload on test failures
  • Good practices maintained: if-no-files-found: ignore and retention-days: 7 configurations are preserved

✅ Compatibility Analysis

Node.js Runtime Compatibility:

  • v5 supports Node.js v24.x (as noted in release notes)
  • This workflow uses Node.js v20, which is fully supported (node-version: '20' at line 23)
  • GitHub Actions runners include Node.js 20 by default, ensuring compatibility

Breaking Changes:

  • The v5 release is primarily a Node.js runtime update
  • No breaking changes to the action's API or parameters
  • All existing parameters (name, path, if-no-files-found, retention-days) remain compatible

Dependencies:

  • v5 bumps @actions/artifact to v4.0.0 (internal dependency)
  • No changes required to workflow configuration

✅ Security Considerations

  • Trusted source: Official GitHub Actions maintained by GitHub
  • No security vulnerabilities: This is a maintenance upgrade, not a security patch
  • Minimal risk: Only executes on test failure to upload diagnostic artifacts
  • Proper scoping: Artifacts are scoped to workflow runs with 7-day retention

✅ Performance Considerations

  • Expected improvements: v5 includes artifact service updates that may improve upload speeds
  • No regressions expected: Upload behavior remains the same from user perspective
  • Minimal overhead: Only runs conditionally on test failures

✅ Test Coverage

  • Existing tests apply: No functional changes to the E2E test suite
  • CI will validate: This PR will run the E2E workflow itself, validating the upgrade
  • Low risk: Artifact uploads are non-critical (diagnostic only)

🔍 Potential Issues

None identified. This is a straightforward dependency upgrade with:

  • ✅ No API breaking changes
  • ✅ No configuration changes required
  • ✅ No known compatibility issues with the current setup

📋 Recommendations

Immediate Action:
APPROVE and MERGE - This is a safe, low-risk upgrade that keeps dependencies current.

Post-Merge Verification:

  1. Monitor the next E2E test run (especially if it fails) to ensure artifacts upload successfully
  2. Verify artifact retention behavior remains consistent

📚 References


Reviewer Assessment:Ready to Merge

This Dependabot upgrade follows best practices for dependency maintenance and poses no risk to the platform's CI/CD pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants