send messages retry failure handling #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkt4nk
force-pushed
the
chore/send-messages-failure-retry
branch
2 times, most recently
from
ee19421 to
0ca043c
Compare
jaredlewis
requested changes
Mar 3, 2021
entity_emailer/interface.py
Outdated
|
|
||
| # Update the emails as sent | ||
| to_send.update(sent=current_time) | ||
| Email.objects.filter(id__in=emails_sent_ids).update(sent=current_time) |
Contributor
There was a problem hiding this comment.
I think in this scenario we are going to have to save each one of these one at a time inside of the loop. Otherwise you run into a similar situation where if this process gets terminated in the middle of sending 1000 emails and you are on number 900, the next time the process starts you will be sending 900 duplicate emails. Unfortunately its inefficient but I cant think of another alternative that fully solves the problem
| def setUp(self): | ||
| G(Medium, name='email') | ||
|
|
||
| @override_settings(DISABLE_DURABILITY_CHECKING=True) |
Contributor
There was a problem hiding this comment.
I think you can apply this at the class level if you need every method to be overridden
Contributor
Author
There was a problem hiding this comment.
oh shit, I only stubbed out the only test in this class that I need to stay undecorated
thinkt4nk
force-pushed
the
chore/send-messages-failure-retry
branch
from
0ca043c to
5b7b51d
Compare
thinkt4nk
force-pushed
the
chore/send-messages-failure-retry
branch
from
5b7b51d to
8c573a5
Compare
jaredlewis
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ambitioninc/ambition/pull/8507#issuecomment-759612953