Consider files with '.hh' extension as C++ headers #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, these files are considered to be C system headers. This change affects the expected include order with respect to '.hh' files. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced May 3, 2022
wjwwood
approved these changes
May 4, 2022
|
jacobperron
added a commit
to ros2/rviz
that referenced
this pull request
May 5, 2022
Related to ament/ament_lint#374 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
I overlooked one instance of .hh files in rviz, fixed in ros2/rviz#858
|
jacobperron
added a commit
to ros2/rviz
that referenced
this pull request
May 5, 2022
Related to ament/ament_lint#374 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 5, 2022
Without this change, these files are considered to be C system headers. This change affects the expected include order with respect to '.hh' files. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/rviz
that referenced
this pull request
May 5, 2022
Related to ament/ament_lint#374 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 9, 2022
jacobperron
added a commit
to ros2/rviz
that referenced
this pull request
May 9, 2022
Related to ament/ament_lint#374 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 9, 2022
Without this change, these files are considered to be C system headers. This change affects the expected include order with respect to '.hh' files. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 9, 2022
|
Upstream PR: cpplint/cpplint#202 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, these files are considered to be C system headers.
This change affects the expected include order with respect to '.hh' files.
I ran across this since Gazebo uses the .hh extension for C++ headers.
If this change is acceptable, then I'll check for any instances across the ROS 2 core packages and propose a fix upstream.