Do not implement diagonals in get_available_exits early #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagonal directions in the `get_available_exits` function is does not need to be implemented until later in the chapters, and is done so [here](https://github.com/thebracket/rustrogueliketutorial/blob/master/book/src/chapter_7.md#allowing-diagonal-movement). This PR cleans up the earlier implementation so that the reader doesnt get confused by an early implementation of diagonals that is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagonal directions in the
get_available_exitsfunction is doesnot need to be implemented until later in the chapters, and is done so
here. This
PR cleans up the earlier implementation so that the reader doesnt get
confused by an early implementation of diagonals that is not needed.