Skip to content

Conversation

@AnandajithS
Copy link
Contributor

Closes issue #70

This PR fixes the issue of groups shown in status updates and instead displays members by their tracks.

Copy link
Contributor

@chimnayajith chimnayajith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, it looks good with just a small suggestion.

I noticed that queries.rs hasn’t been changed in this PR, but I think it needs some updates related to this change -specifically, the query to fetch members is not fetching the track from root.

@chimnayajith
Copy link
Contributor

Thanks for the update! Just one quick request: could you squash the commits into a single one to keep the commit history clean?

Other than that, LGTM!

@hrideshmg
Copy link
Member

I wonder what will happen when a member does not have a track assigned to them, like for eg - first years. Wouldn't it just print "Track - "? We should probably have some logic to support this edge case.

@AnandajithS
Copy link
Contributor Author

AnandajithS commented Jun 7, 2025

I wonder what will happen when a member does not have a track assigned to them, like for eg - first years. Wouldn't it just print "Track - "? We should probably have some logic to support this edge case.

I've made the required changes

  • Updated the type of track to Option<String> to handle null values
  • Added a match statement in format_defaulters to properly handle track

@hrideshmg
Copy link
Member

hrideshmg commented Jun 8, 2025

Looks good so far, guess we'll see if it works tonight :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants