Implementing iterable Volumes - fixing issue #192

[bkuzmic]

PR for #192. Extending iterable of Volumes plus providing a couple of new puzzles

[0crat]

Job #201 is now in scope, role is REV

[0crat]

This pull request #201 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

[paulodamaso]

@bkuzmic Made some comments, please take a look

[paulodamaso]

@bkuzmic Just some formatting issues now, please take a look

[paulodamaso]

@bkuzmic Good, thanks for the fixes

[paulodamaso]

@rultor merge

[rultor]

@rultor merge

@paulodamaso Thanks for your request. @amihaiemil Please confirm this.

[amihaiemil]

@bkuzmic Looks good, thanks! And no, I don't have any code formatter for IntelliJ (for the imports thing)... just leave it like that.

[amihaiemil]

@rultor merge it

[rultor]

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge it

@amihaiemil @bkuzmic Oops, I failed. You can see the full log here (spent 2min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 13656
+ echo '1.68.1 24dc2a841'
1.68.1 24dc2a841
+ date
Thu Dec  6 14:02:34 CET 2018
+ uptime
 14:02:34 up 151 days, 23:46,  0 users,  load average: 7.38, 7.69, 7.39
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
+ pull_title='Implementing iterable Volumes - fixing issue #192'
+ author=amihaiemil
+ directory=
+ head=git@github.com:amihaiemil/docker-java-api.git
+ pull_id=201
+ fork=git@github.com:bkuzmic/docker-java-api.git
+ fork_branch=issue-192-extend-volumes
+ squash=false
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:amihaiemil/docker-java-api.git' '--env=pull_id=201' '--env=fork=git@github.com:bkuzmic/docker-java-api.git' '--env=fork_branch=issue-192-extend-volumes' '--env=head_branch=master' '--env=pull_title=Implementing iterable Volumes - fixing issue #192' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:amihaiemil/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=201'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:bkuzmic/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-192-extend-volumes'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=Implementing iterable Volumes - fixing issue #192'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=201'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-192-extend-volumes'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=Implementing iterable Volumes - fixing issue #192'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=amihaiemil_docker-java-api_201
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:amihaiemil/docker-java-api.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=201'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-192-extend-volumes'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=Implementing iterable Volumes - fixing issue #192'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly

[amihaiemil]

@rultor try to merge again

[rultor]

@rultor try to merge again

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor try to merge again

@amihaiemil Done! FYI, the full log is here (took me 2min)

[0crat]

Job was finished in 5 hours, bonus for fast delivery is possible (see §36)

[0crat]

The job #201 is now out of scope

[0crat]

Order was finished: +20 point(s) just awarded to @paulodamaso/z

[0crat]

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

[coveralls]

Pull Request Test Coverage Report for Build 352

• 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.6%) to 85.053%

---

Totals
Change from base Build 346:	0.6%
Covered Lines:	478
Relevant Lines:	562

---

💛 - Coveralls