make root div focusable so that navigation keys work even when search… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input is not focused
chore: use offsetHeight to calculate list height
…p#122) * chore: add data-disabled to item * docs: use data-attributes in docs and examples
* feat: add default value prop * fix: revert example * fix: check for undefined toLowerCase * fix: prettier test format
* chore: use forceMount from group as fallback * fix: undefined forceMount * fix: check for null/undefined for group id * fix: add forceMount to deps Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com> --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
* move command-score into local dep * remove command-score dep * add tests from dip#16 * update lockfile
* docs: add forceMount prop * Apply suggestions from code review --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
fix: skip item select with enter key while composing
* chore: remove select item via mouse event * chore: update examples to use hover * chore: disable pointer selection via prop * fix bug from merge, my bad * upgrade next --------- Co-authored-by: João Pedro Magalhães <joaopsilvamagalhaes@gmail.com> Co-authored-by: paco <34928425+pacocoursey@users.noreply.github.com>
* Fix forceMount too many rerenders * fix format --------- Co-authored-by: João Pedro Magalhães <joaopsilvamagalhaes@gmail.com>
* fix: only scroll into view on first render and via keyboard * refactor: remove unnecessary code --------- Co-authored-by: João Pedro Magalhães <joaopsilvamagalhaes@gmail.com>
* deps: react-dialog version * use exact --------- Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
add keywords prop to the item component
* feat: add asChild prop * refactor: move logic to a function * chore: cut comment * chore: add primitive dep and remove slot dep * build: update pnpm-lock --------- Co-authored-by: João Pedro Magalhães <joaopsilvamagalhaes@gmail.com> Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com>
* Fix suggestions list label. * Fix loading progressbar label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… input is not focused