Skip to content

Conversation

@SteveHigham
Copy link

This is a big change and IS NOT READY TO BE MERGED YET.
I am going through and reviewing all the changes to make sure they are correct.
If anyone else can have a look as well that would be great. All comments appreciated.

See the notes.txt file for further comments.

@SteveHigham
Copy link
Author

Hmm. The build has failed but this looks like a problem on your side?

npm WARN prepare removing existing node_modules/ before installation

npm ERR! Error while executing:

npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/ethereumjs/ethereumjs-abi.git

npm ERR!

npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.112.3' to the list of known hosts.

npm ERR! Permission denied (publickey).

npm ERR! fatal: Could not read from remote repository.

npm ERR!

npm ERR! Please make sure you have the correct access rights

npm ERR! and the repository exists.

npm ERR!

npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:

npm ERR! /home/travis/.npm/_logs/2020-11-30T17_23_28_453Z-debug.log

This runs on the CI system so it should work.
Truffle version 4 runs with some errors.
This version does now run which is an improvement.
We see multiple out of gas errors.
@SteveHigham
Copy link
Author

Updated coverage tool to resolve out of gas issues.
This change is now ready for review.

@SteveHigham SteveHigham marked this pull request as ready for review December 4, 2020 22:16
@aalavandhan
Copy link
Member

@SteveHigham Thanks a lot for this. Sorry couldn't get back to you sooner.

I think we're looking to move out of truffle and into buidler / etheres framework.

It should be merged in soon.
#164

If you're still looking to contribute you can pick something out of the open issues 👍

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants