build: Automated release process #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-lu
reviewed
Sep 18, 2020
haoliu-amp
suggested changes
Sep 21, 2020
| }, | ||
| frameworks: ['mocha', 'chai'], | ||
| files: ['amplitude-snippet.min.js', 'build/snippet-tests.js', 'build/tests.js'], | ||
| // files: ['amplitude-snippet.min.js', 'build/snippet-tests.js', 'build/tests.js'], @TODO: Fix flaky build/snippet-tests.js and re-enable |
Contributor
There was a problem hiding this comment.
Should we remove this commented code?
Contributor
Author
There was a problem hiding this comment.
IMO leave it as a todo until we can fix then re-enable the flaky snippet tests
kelsonpw
reviewed
Sep 21, 2020
kelsonpw
approved these changes
Sep 21, 2020
haoliu-amp
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Repo collaborators will now be able to do a release by running a workflow from the Actions tab.
Implemented semantic-release for automatic releases (release.yml and release.config.js)
Added test.yml action. Includes testing on multiple LTS node versions
Added deploy_s3.py based off internal deploy script
Updated CONTRIBUTING.md explaining commit conventions and release process
Added pull request template
Added semantic PR bot to check for PR titles (config is here)
Added secrets as env variables
New release workflow tested on personal fork
TODO
masteras development,releaseas release