refactor(supported-platforms): Remove React Native Support #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: Removed support for React Native We recently released an entirely new SDK focused entirely on React Native support, this can be found at https://github.com/amplitude/Amplitude-ReactNative. We will be writing a migration guide for users looking to move to the new React Native SDK.
kelsonpw
requested review from
ajhorst,
haoliu-amp,
jooohhn,
kelvin-lu and
yuhao900914
and removed request for
jooohhn and
kelvin-lu
kelvin-lu
reviewed
Mar 9, 2021
README.md
Outdated
| ## React Native | ||
| This library now supports react-native. It has two dependencies on react-native modules you will have to install yourself: | ||
| ## Deprecated - React Native | ||
| As of > v7.4.4, this SDK no longer has support for react-native. We recently released a new SDK focused on providing a React Native and cross-platform first approach. [Amplitude React Native SDK](https://github.com/amplitude/Amplitude-ReactNative) |
Contributor
There was a problem hiding this comment.
nit: any strong opinions between the last working build vs. the first breaking build (>= 8.0.0) ?
Contributor
Author
There was a problem hiding this comment.
yep, i like that wording better, added! @kelvin-lu
ajhorst
reviewed
Mar 9, 2021
src/options.js
Outdated
| * @property {boolean} [optOut=`false`] - Whether or not to disable tracking for the current user. | ||
| * @property {function} [onError=`() => {}`] - Function to call on error. | ||
| * @property {string} [platform=`Web`|`iOS`|`Android`] - Platform device is running on. `Web` is a browser (including mobile browsers). `iOS` and `Android` are relevant only for react-native apps. | ||
| * @property {string} [platform=`Web`] - Platform device is running on. Defailts to `Web` (browser, including mobile browsers). |
Contributor
There was a problem hiding this comment.
nit, should be Defaults to 😛
Contributor
Author
There was a problem hiding this comment.
i like how my typo has the word fail in it 😄
thx for catching
ajhorst
approved these changes
Mar 12, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGES: Removed support for React Native
We recently released an entirely new SDK focused completely on React Native support, this can be found at
https://github.com/amplitude/Amplitude-ReactNative.
We will be writing a migration guide for users looking to move to the new React Native SDK.
Checklist