Skip to content

fix: reduce log level of cookie test #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Bug bounty test - PLEASE DO NOT APPROVE. jfsyew
merged 3 commits into from
May 18, 2021
Merged

fix: reduce log level of cookie test #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87213e7
fix: reduce log level of cookie test
kelvin-lu May 18, 2021
43f21b9
fix: remove file
kelvin-lu May 18, 2021
ba8d335
fix: test thats failing
kelvin-lu May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/base-cookie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const areCookiesEnabled = (opts = {}) => {
} catch (e) {
utils.log.warn(`Error thrown when checking for cookies. Reason: "${e}"`);
} finally {
utils.log.warn(`Cleaning up cookies availability test`);
utils.log.info(`Cleaning up cookies availability test`);
set(cookieName, null, opts);
}
return _areCookiesEnabled;
Expand Down
2 changes: 1 addition & 1 deletion test/base-cookie.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('cookie', function () {

describe('when error is thrown during check', () => {
it('should cleanup cookies', () => {
const stubLogInfo = sinon.stub(utils.log, 'info').throws('Stubbed Exception');
const stubLogInfo = sinon.stub(utils.log, 'info').onFirstCall().throws('Stubbed Exception');
const spyLogWarning = sinon.spy(utils.log, 'warn');
const cookieName = Constants.COOKIE_TEST_PREFIX + base64Id();
const res = cookie.areCookiesEnabled();
Expand Down