Skip to content

fix: allow amplitude to be imported/required during SSR #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: allow amplitude to be imported/required during SSR #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Entry point
import Amplitude from './amplitude';

const old = window.amplitude || {};
const old = (typeof window !== 'undefined' && window.amplitude) || {};
const newInstance = new Amplitude();
newInstance._q = old._q || [];

Expand Down
3 changes: 2 additions & 1 deletion src/language.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var getLanguage = function () {
return (
(navigator && ((navigator.languages && navigator.languages[0]) || navigator.language || navigator.userLanguage)) ||
(typeof navigator !== 'undefined' &&
((navigator.languages && navigator.languages[0]) || navigator.language || navigator.userLanguage)) ||
''
);
};
Expand Down
2 changes: 1 addition & 1 deletion src/localstorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if (BUILD_COMPAT_LOCAL_STORAGE) {

if (windowLocalStorageAvailable()) {
localStorage = window.localStorage;
} else if (window.globalStorage) {
} else if (typeof window !== 'undefined' && window.globalStorage) {
// Firefox 2-3 use globalStorage
// See https://developer.mozilla.org/en/dom/storage#globalStorage
try {
Expand Down