Skip to content

fix: handle 400 error with invalid id lengths #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix: handle 400 error with invalid id lengths #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics-core/src/plugins/destination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export class Destination implements DestinationPlugin {
const dropIndex = [
...Object.values(res.body.eventsWithInvalidFields),
...Object.values(res.body.eventsWithMissingFields),
...Object.values(res.body.eventsWithInvalidIdLengths),
...res.body.silencedEvents,
].flat();
const dropIndexSet = new Set(dropIndex);
Expand Down
1 change: 1 addition & 0 deletions packages/analytics-core/src/utils/response-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const buildResponse = (responseJSON: Record<string, any>): Response | nul
missingField: responseJSON.missing_field ?? '',
eventsWithInvalidFields: responseJSON.events_with_invalid_fields ?? {},
eventsWithMissingFields: responseJSON.events_with_missing_fields ?? {},
eventsWithInvalidIdLengths: responseJSON.events_with_invalid_id_lengths ?? {},
epsThreshold: responseJSON.eps_threshold ?? 0,
exceededDailyQuotaDevices: responseJSON.exceeded_daily_quota_devices ?? {},
silencedDevices: responseJSON.silenced_devices ?? [],
Expand Down
1 change: 1 addition & 0 deletions packages/analytics-core/test/plugins/destination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ describe('destination', () => {
missingField: '',
eventsWithInvalidFields: { a: [0] },
eventsWithMissingFields: { b: [] },
eventsWithInvalidIdLengths: {},
silencedEvents: [],
},
});
Expand Down
3 changes: 3 additions & 0 deletions packages/analytics-core/test/utils/response-builder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ describe('response-builder', () => {
missing_field: 'field',
events_with_invalid_fields: { a: 1 },
events_with_missing_fields: { a: 2 },
events_with_invalid_id_lengths: {},
eps_threshold: 1,
exceeded_daily_quota_devices: { a: 3 },
silenced_devices: ['a'],
Expand All @@ -68,6 +69,7 @@ describe('response-builder', () => {
missingField: 'field',
eventsWithInvalidFields: { a: 1 },
eventsWithMissingFields: { a: 2 },
eventsWithInvalidIdLengths: {},
epsThreshold: 1,
exceededDailyQuotaDevices: { a: 3 },
silencedDevices: ['a'],
Expand All @@ -90,6 +92,7 @@ describe('response-builder', () => {
missingField: '',
eventsWithInvalidFields: {},
eventsWithMissingFields: {},
eventsWithInvalidIdLengths: {},
epsThreshold: 0,
exceededDailyQuotaDevices: {},
silencedDevices: [],
Expand Down
1 change: 1 addition & 0 deletions packages/analytics-types/src/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface InvalidRequestBody {
missingField: string;
eventsWithInvalidFields: { [eventField: string]: number[] };
eventsWithMissingFields: { [eventField: string]: number[] };
eventsWithInvalidIdLengths: { [eventField: string]: number[] };
epsThreshold: 0;
exceededDailyQuotaDevices: { [deviceId: string]: number };
silencedDevices: string[];
Expand Down