Skip to content

feat: integrate core package into experiment sdk #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Jan 26, 2022
Merged

feat: integrate core package into experiment sdk #16

merged 81 commits into from
Jan 26, 2022

Conversation

@bgiori
Copy link
Collaborator

@bgiori bgiori commented Nov 29, 2021 •
edited
Loading

Summary

  • Add core dependency to experiment package.
  • Implement new initializer which utilizes core package.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@bgiori bgiori mentioned this pull request Nov 30, 2021
Merged
1 task
@bgiori bgiori requested a review from curtisliu December 1, 2021 20:52
justin-fiedler
justin-fiedler reviewed Dec 6, 2021
View reviewed changes
@bgiori bgiori changed the base branch from core to main January 13, 2022 23:26
@calvinkcox-divvyhomes calvinkcox-divvyhomes mentioned this pull request Jan 17, 2022
Closed
@bgiori bgiori changed the title feat: add dependency on core package feat: integrate core package into experiment sdk Jan 26, 2022
@bgiori bgiori merged commit 7ff0540 into main Jan 26, 2022
@bgiori bgiori deleted the experiment-core branch January 26, 2022 23:05
kelsonpw pushed a commit to kelsonpw/experiment-js-client that referenced this pull request Jul 10, 2023
@bgiori
chore: update demo and dev dependencies to fix vulns (amplitude#16)
b56a8c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curtisliu curtisliu Awaiting requested review from curtisliu

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

1 more reviewer

@justin-fiedler justin-fiedler justin-fiedler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgiori @justin-fiedler