Skip to content

fix: intialize with custom user provider #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: intialize with custom user provider #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/experiment-browser/src/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ const initialize = (
const connector = AnalyticsConnector.getInstance(instanceName);
if (!instances[instanceKey]) {
config = {
...config,
userProvider: new DefaultUserProvider(
connector.applicationContextProvider,
config?.userProvider,
),
...config,
};
instances[instanceKey] = new ExperimentClient(apiKey, config);
}
Expand Down
12 changes: 12 additions & 0 deletions packages/experiment-browser/test/factory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,15 @@ test('Experiment.initialize, same instance name, different api key, different ob
const client2 = Experiment.initialize(OTHER_KEY);
expect(client2).not.toBe(client1);
});

test('Experiment.initialize, custom user provider wrapped correctly', async () => {
const customUserProvider = {
getUser: () => {
return { user_id: 'user_id' };
},
};
const client1 = Experiment.initialize(API_KEY, {
userProvider: customUserProvider,
});
expect(client1.getUserProvider()).not.toStrictEqual(customUserProvider);
});