Skip to content

Chore: var variables to const #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Chore: var variables to const #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e57e0eb
Merge pull request #1 from amrlabib/master
MateusAndrade Jan 14, 2020
2f85b2b
chore: changing var values to const
MateusAndrade Jan 14, 2020
92d70eb
fix: conflicts
MateusAndrade Jan 14, 2020
36ccd46
chore: changing README.MD and App.js to use const
MateusAndrade Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function MyTimer({ expiryTimestamp }) {
<button onClick={resume}>Resume</button>
<button onClick={() => {
// Restarts to 5 minutes timer
var t = new Date();
const t = new Date();
t.setSeconds(t.getSeconds() + 300);
restart(t)
}}>restart</button>
Expand All @@ -35,7 +35,7 @@ function MyTimer({ expiryTimestamp }) {
}

export default function App() {
var t = new Date();
const t = new Date();
t.setSeconds(t.getSeconds() + 600); // 10 minutes timer
return (
<div>
Expand Down
20 changes: 20 additions & 0 deletions src/useTimer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,26 @@ export default function useTimer(settings) {
setExpiryTimestamp(newExpiryTimestamp);
}


// Timer expiry date calculation
function calculateExpiryDate() {
const now = new Date().getTime();
const distance = expiryTimestamp - now;
const days = Math.floor(distance / (1000 * 60 * 60 * 24));
const hours = Math.floor((distance % (1000 * 60 * 60 * 24)) / (1000 * 60 * 60));
const minutes = Math.floor((distance % (1000 * 60 * 60)) / (1000 * 60));
const seconds = Math.floor((distance % (1000 * 60)) / 1000);
if(seconds < 0) {
reset();
isValidOnExpire(onExpire) && onExpire();
} else {
setSeconds(seconds);
setMinutes(minutes);
setHours(hours);
setDays(days);
}
}

// didMount effect
useEffect(() => {
start();
Expand Down