Skip to content

data_offload: Fix timing violation #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2021
Merged

data_offload: Fix timing violation #727

merged 1 commit into from
Sep 22, 2021

Conversation

mihnagy
Copy link
Contributor

@mihnagy mihnagy commented Aug 10, 2021

Tested on ZC706 + DAQ2

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mihnagy mihnagy requested a review from a team August 10, 2021 08:33
@Yamakaja
Copy link
Contributor

Did you run the testbenches against this modification? I'd be interested specifically in the outcome when the ready / valid signals aren't constantly high but oscillating (0, 0, 0, 1, repeat), for the case where those are always high i agree that the behavior should be identical.

@mihnagy
Copy link
Contributor Author

mihnagy commented Aug 10, 2021

tlast should be generated on the last data beat while having tvalid and tready both active. Regardless of them switching constantly or not, the data should be valid and counted only when valid and ready are both active.

@mihnagy mihnagy closed this Aug 20, 2021
@mihnagy mihnagy deleted the data_offload_fixes branch August 20, 2021 07:42
@mihnagy mihnagy restored the data_offload_fixes branch September 20, 2021 10:39
@mihnagy mihnagy reopened this Sep 20, 2021
@mihnagy mihnagy mentioned this pull request Sep 21, 2021
Merged
acostina
acostina requested changes Sep 21, 2021
View reviewed changes
@mihnagy mihnagy requested a review from acostina September 21, 2021 13:00
@acostina
Copy link
Contributor

acostina commented Sep 22, 2021 •
edited
Loading

Can you squash the two commits into a single one ?
Otherwise, looks good.

@mihnagy
Copy link
Contributor Author

mihnagy commented Sep 22, 2021

Ok, done

@mihnagy mihnagy merged commit 1fe0d5f into analogdevicesinc:master Sep 22, 2021
@Yamakaja
Copy link
Contributor

@mihnagy I'm sorry i didn't get to test this properly before, but i believe the changes in this PR broke something about my OFDM radar ... not yet sure what exactly went wrong.

@Yamakaja Yamakaja mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acostina acostina acostina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mihnagy @CLAassistant @Yamakaja @acostina