Skip to content

Conversation

@bnogas
Copy link
Contributor

@bnogas bnogas commented Sep 15, 2025

Summary by cubic

Send WebRTC inbound-rtp stats to Pion over the DataChannel every 5 seconds to enable client-side metrics monitoring. Supports Linear CLO-410 by exposing packet loss, jitter, and frame stats for both audio and video.

  • New Features
    • Collect RTCStatsReport every 5s once the connection is established and DataChannel is open.
    • Filter inbound-rtp (audio/video) and send JSON messages: { message_type: "remote_rtp_stats", data: report }.
    • Automatically stops collection on disconnect/cleanup.

Copilot AI review requested due to automatic review settings September 15, 2025 09:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to send WebRTC inbound-rtp metrics to a remote server via DataChannel. The implementation allows real-time monitoring of video and audio reception statistics.

Key changes:

  • Added automatic stats collection every 5 seconds once WebRTC connection is established
  • Implemented filtering and transmission of inbound-rtp metrics for both video and audio streams
  • Added proper cleanup of stats collection interval during shutdown

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@bnogas bnogas requested a review from ao-anam September 15, 2025 10:03
ao-anam
ao-anam previously approved these changes Sep 15, 2025
Copy link
Contributor

@ao-anam ao-anam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the copilot comments but other than that LGTM!

@bnogas bnogas force-pushed the bart/clo-410-measure-client-side-metrics-frozen-frames-etc branch from 6c1ed51 to ed45ffa Compare September 15, 2025 19:06
@bnogas bnogas force-pushed the bart/clo-410-measure-client-side-metrics-frozen-frames-etc branch from ed45ffa to c15f1eb Compare September 15, 2025 19:14
@bnogas bnogas force-pushed the bart/clo-410-measure-client-side-metrics-frozen-frames-etc branch from c15f1eb to d49dbec Compare September 15, 2025 19:15
@bnogas bnogas removed the low risk label Sep 15, 2025
@bnogas bnogas merged commit 1b190d6 into main Sep 15, 2025
3 checks passed
@bnogas bnogas deleted the bart/clo-410-measure-client-side-metrics-frozen-frames-etc branch September 15, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants