Skip to content

RUP - Implementa job para actualizar estado de recetas#2029

Merged
MCele merged 1 commit intomasterfrom
RUP-465
Aug 22, 2025
Merged

RUP - Implementa job para actualizar estado de recetas#2029
MCele merged 1 commit intomasterfrom
RUP-465

Conversation

@ma7payne
Copy link
Copy Markdown
Contributor

@ma7payne ma7payne commented Mar 10, 2025 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/RUP-465

Funcionalidad desarrollada

  1. Implementa job que actualiza recetas: venciendo aquellas con más de 30 días en estados "vigente" + "sin dispensa" o "vigente" + "dispensa-parcial" y activando como "vigente" las "pendientes" dentro de su fecha de vigencia.

UserStories llegó a completarse

  • Si
  • No

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere agregar el siguiente documento a la coleccion recetasParametros:

{ "key": "fechaLimite", "value": "30", "type": "number", "nombre": "Fecha limite para verificar vencimiento" }

@ma7payne ma7payne requested review from a team as code owners March 10, 2025 15:34
silviroa
silviroa previously requested changes Mar 26, 2025
View reviewed changes
Comment thread modules/recetas/recetasController.ts Outdated
@silviroa silviroa added the changes requested Se solicitaron cambios label Mar 26, 2025
@github-actions github-actions bot added the has_conflicts Tiene conlfictos label Apr 10, 2025
@ma7payne ma7payne added changes done and removed changes requested Se solicitaron cambios has_conflicts Tiene conlfictos labels Apr 21, 2025
@github-actions github-actions bot added the has_conflicts Tiene conlfictos label May 6, 2025
@ma7payne ma7payne removed the has_conflicts Tiene conlfictos label May 16, 2025
@github-actions github-actions bot added the has_conflicts Tiene conlfictos label Jun 3, 2025
@ma7payne ma7payne removed the has_conflicts Tiene conlfictos label Jun 5, 2025
@MCele MCele added the receta label Jun 11, 2025
negro89
negro89 reviewed Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@negro89 negro89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La lógica en gral esta bien pero dejo algunas observaciones que me parecen importantes.
La funcion renovar no se está usando.

Comment thread modules/recetas/recetasController.ts
Comment thread modules/recetas/recetasController.ts
Comment thread modules/recetas/recetasController.ts Outdated
@negro89 negro89 added changes requested Se solicitaron cambios and removed changes done labels Aug 14, 2025
MCele
MCele reviewed Aug 20, 2025
View reviewed changes
Comment thread modules/recetas/recetasController.ts Outdated
@MCele MCele changed the title RUP - Implementa job para vencimiento de recetas RUP - Implementa job para actualizar estado de recetas Aug 22, 2025
@MCele MCele self-requested a review August 22, 2025 15:14
@MCele MCele requested a review from silviroa August 22, 2025 16:46
@MCele MCele dismissed silviroa’s stale review August 22, 2025 17:12

aprobado por Chichi

@MCele MCele merged commit 6b1c42f into master Aug 22, 2025
2 checks passed
@MCele MCele deleted the RUP-465 branch August 22, 2025 17:12
liquid36 pushed a commit that referenced this pull request Aug 27, 2025
@semantic-release-bot
chore(release): 5.134.0 [skip ci]
097003a 
# [5.134.0](v5.133.0...v5.134.0) (2025-08-27)

### Bug Fixes

* **PACS:** Agrega logs en pacs ([#2093](#2093)) ([c30c9ef](c30c9ef))

### Features

* **RUP:** implementa job para actualizar estado de recetas ([#2029](#2029)) ([6b1c42f](6b1c42f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MCele MCele MCele approved these changes

@negro89 negro89 negro89 approved these changes

@MarianoCampetella MarianoCampetella Awaiting requested review from MarianoCampetella MarianoCampetella is a code owner automatically assigned from andes/code-review

@aldoEMatamala aldoEMatamala Awaiting requested review from aldoEMatamala aldoEMatamala is a code owner automatically assigned from andes/code-review

@silviroa silviroa Awaiting requested review from silviroa

Assignees

No one assigned

Labels

changes requested Se solicitaron cambios receta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ma7payne @silviroa @MCele @negro89