Removed duplicate entries for WithAlias from UsageString #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refines the output of the UsageString by deduplicating flag alias entries and using a more concise formatting style. Key changes include:
- Gathering flag data into a new struct and deduplicating alias entries.
- Replacing flag.VisitAll loops with map-based iterations and sorted output.
- Adding a test to ensure the usage string output is non-empty and bumping the version.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| usage.go | Refactors usage string generation to remove duplicate alias entries and improves alias formatting. |
| alias_test.go | Adds test coverage for the updated UsageString output. |
| VERSION | Bumps version from v2.0.11 to v2.0.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UsageString()was printing the aliases registered in thetree.flagSet, but they needed to be skipped. This skips the duplicate lines from the output and uses the concise format instead.