-
Notifications
You must be signed in to change notification settings - Fork 1
Updated error handling and value assignment tests #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates error handling with typed error structs, enhances flag value assignment, and expands tests for value parsing and assignment.
- Store persistent pointers for boolean flags and update flag registration
- Replace generic
fmt.Errorf
errors withErrLoadFailure
/ErrValidationFailure
- Add deep-copy logic in
Value.Assign
and comprehensive tests forValue.Set
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
mutations_new.go | Use a persistent pointer for bool flags and update BoolVar call |
loading.go | Swap fmt.Errorf for structured load/validation error types |
fruit.go | Introduce IsBoolFlag , use ErrInvalidValue , add deep-copy in Assign |
errors.go | Define ErrLoadFailure , ErrValidationFailure , ErrValue , and Unwrap methods |
conversions.go | Change toInt to reject float strings and check int32 overflow |
conversions_test.go | Adjust tests to expect errors on float-to-int parsing |
assure.go | Migrate validation errors to use ErrValue with standardized messages |
fruit_test.go | New tests covering all Value.Set mutagenesis cases |
figtree_test.go | Remove obsolete invalid-bool test cases |
VERSION | Bump version from v2.0.13 to v2.0.14 |
Comments suppressed due to low confidence (1)
fruit.go:182
- [nitpick] You’ve added deep-copy logic for
ListFlag
andMapFlag
inAssign
, but there are no tests verifying that mutations of the original flag do not affect the storedValue
. Consider adding tests to cover these deep-copy paths.
case *MapFlag:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.