Swap bytes when building IPv6 addresses. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an example, the IPv6 address fe80::1 is represented in memory (in a sin6_addr.s6_addr) as: [0xfe, 0x80, 0x00, ..., 0x01] So to construct an IPv6 address from 16-bit values, as is required by net::Ipv6Addr::new, these should be passed as 0xfe80, 0x0000, etc. However, the make_int16() function here was building them as 0x80fe, etc. (or rather, it was being *called* in such a way to construct such swapped integers). Because this function is used only to build IPv6 addresses, simply swapping the order of its parameters is sufficient to properly construct IPv6 addresses.
2 similar comments
|
Huh, good catch - and thanks for the PR! Would you mind writing a test for this? Something like: assert_eq!(make_int16(0xff, 0x00), 0xff00) |
|
OK, I've updated the branch with the requested test. |
|
Awesome - thanks! 😀 |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, the IPv6 address fe80::1 is represented in memory (in a
sin6_addr.s6_addr) as:
[0xfe, 0x80, 0x00, ..., 0x01]
So to construct an IPv6 address from 16-bit values, as is required by
net::Ipv6Addr::new, these should be passed as 0xfe80, 0x0000, etc.
However, the make_int16() function here was building them as 0x80fe,
etc. (or rather, it was being called in such a way to construct such
swapped integers). Because this function is used only to build IPv6
addresses, simply swapping the order of its parameters is sufficient to
properly construct IPv6 addresses.