Date.create is undefined

[maca]

Either by making a build with only core, date and formats and by importing sugar-full.min.js, the create method for Date is not defined, I am interested in the natural language date parsing

Date.create
undefined

--EDIT

Using sinon fakeTimers restores Date methods and deletes Date.create, following code will break Date.create:

  it('should be past due if due has passed', function(){
    clock = sinon.useFakeTimers(new Date(2014,1,1).getTime());
    expect( task.is_past_due ).to.eq(false)
    clock = sinon.useFakeTimers(new Date(2015,1,1).getTime());
    expect( task.is_past_due ).to.eq(true)
    clock.restore();
  });

[maca]

Updated my code, reads better.

  it('is past due if due has passed', function(){
    task.due = Date.create('one week ago'); 
    expect( task.is_past_due ).to.eq(true);
  });

[andrewplummer]

Yes, Sinon actually overwrites the entire Date object, so it's not safe to use with Sugar.

[faridnsh]

You should report this to sinon, so they can support extensions to Date and other fake global objects.

[andrewplummer]

I remember having an in depth look at it previously (may have even reported)... in the end I know they're doing some very tricky stuff to make their magic happen, so I'm not sure it's possible, but it's a good idea to have another look.

[andrewplummer]

@maca Can you try including Sugar after Sinon and let me know the result?

[maca]

Sorry for the delay :/

I coudn't find the time. Seems the load order is irrelevant. I stopped using fake timers which actually simplified my specs.

[andrewplummer]

Ok... will leave this bug open as a reminder to open an issue with Sinon anyway.

[andrewplummer]

Ah sorry, I think you have to also load Sugar after sinon.useFakeTimers as well. If you do that the Date.create method should be defined.

[andrewplummer]

Ping... did this work out for you?

[kossnocorp]

Nope, it doesn't work.

[andrewplummer]

Ok, sorry for the huge delay on this. Long story short v2.0.0 is soon to be released and there are a few ways this issue will be mitigated.

First global extension is now opt-in so 1) you will have more control over when the globals are extended and 2) create can be reached through the Sugar global object. Additionally, I have updated the code to not hold the natives in a closure. This way if a global is hijacked in the way Sinon does, it will become the target instead of the native class. This could potentially cause other bizarre issues but only in the case that the global is hijacked, which is a big problem to begin with. Sinon does it properly because it's the only way what they're doing will work, so it's worth modifying Sugar to play well with them.

Anyway, if you want to use sinon with Sugar as of v2.0.0 you can just do:

clock = sinon.useFakeTimers(); 
Sugar.extendAll();

Just make sure extendAll (or Sugar.Date.extend) is after useFakeTimers, and it should all work just fine. Tested with latest version 1.17.2.

Also FYI it's only useFakeTimers that's the issue here, the rest of Sinon doesn't hijack globals.