[BUG] Unable to sync/push/pull when server is using Fish shell

[adamrutter]

Describe the bug
I'm unable to sync/push/pull my repo when the Git server is using Fish as the login shell. I am able to sync/push/pull when bash is set as the login shell on the server.

To Reproduce
Steps to reproduce the behavior:

1. chsh -s /usr/bin/fish (or whatever path Fish is installed to) on the server
2. Perform any git operation (including the utilities in Settings/Git configuration) on the Android app
3. See error **An error occured during a Git operation** Invalid packet line header: ]4;

Expected behavior
To be able to perform Git operations the same as when bash is set as the login shell on the server.

Device information

• Device: Google Pixel 3
• OS: stock Android 11
• App version: 1.13.4 (also occurs on 1.3.3 downloaded from F-Droid)

Additional context
Steps to workaround:

1. chsh -s /bin/bash on the server
2. Sync/push/pull on the app as usual

Skimming through this report on bugs.eclipse.org led me to deduce it was the login shell causing the problem.

[msfjarvis]

This is quite interesting. I'm trying to backport changes to the PacketLineIn class where this exception is coming from, assuming it has been fixed in master. Will find out soon enough I guess.

[msfjarvis]

Nevermind the backporting, I was unable to reproduce this at all :/

I created a new user on my desktop PC, changed its login shell to fish, and created a password repository with fake data and it worked just fine for cloning.

What fish version are you on? Maybe that makes a difference 🤷

[adamrutter]

I've just tried creating/cloning a new repo myself, and the behaviour is the same as before.

I'm on version 3.1.2-1ubuntu1.

[msfjarvis]

The exception is thrown here. Attaching a debugger at line 188 for both Bash and Fish login shells does not change the contents of the lineBuffer field, so I'm even more perplexed as to how things differ for you 😕