This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Reland symlink support #1020
Merged
Reland symlink support #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add symlink support to JGit * Fix a typo Co-authored-by: Harsh Shandilya <me@msfjarvis.dev>
Member
Author
|
I tried to break things by adding and deleting symlinks form the pass-test repo, to no avail. All I found was a simple crash when trying to follow a broken symlink, but no crashes that originate in JGit. |
Member
|
Now I can't repro it either with the same repo 😕 Here be dragons, I guess. |
msfjarvis
approved these changes
Aug 14, 2020
msfjarvis
added a commit
to Nosweh/Android-Password-Store
that referenced
this pull request
Aug 20, 2020
* develop: build: bump version Update CHANGELOG Revert "Reland symlink support (android-password-store#1020)" Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Let's move the investigation started in #1019 to this fresh PR.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs