This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Refactor preferences to decouple framework dependency #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SphericalKat <amolele@gmail.com>
…preferences should help when using faked SharedPreferences Signed-off-by: SphericalKat <amolele@gmail.com>
fixes behaviour of getFilesDir Signed-off-by: SphericalKat <amolele@gmail.com>
SphericalKat
requested review from
Skrilltrax,
fmeum and
msfjarvis
as code owners
Signed-off-by: SphericalKat <amolele@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
msfjarvis
changed the title
msfjarvis
reviewed
May 22, 2021
msfjarvis
approved these changes
May 22, 2021
Member
msfjarvis
left a comment
msfjarvis
left a comment
There was a problem hiding this comment.
minor nits, LGTM otherwise.
app/src/main/java/dev/msfjarvis/aps/ui/settings/RepositorySettings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/msfjarvis/aps/ui/settings/RepositorySettings.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/msfjarvis/aps/util/git/operation/GitOperation.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/msfjarvis/aps/util/settings/GitSettings.kt
Outdated
Show resolved
Hide resolved
msfjarvis
added
A-CI-CD
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
…vailable before we use appContext Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Removes dependency on framework for testing migrations.
💡 Motivation and Context
Fixes #1411
💚 How did you test it?
N/A as of now.
📝 Checklist
./gradlew spotlessApply🔮 Next steps
📸 Screenshots / GIFs