This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Refactor BiometricAuthenticator and add proper support for retries #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
added
A-UI-UX
msfjarvis
force-pushed
the
hs/2021-12-29/biometric-retry
branch
from
84aea80 to
d21a22b
Compare
msfjarvis
force-pushed
the
hs/2021-12-29/biometric-retry
branch
from
d21a22b to
9216a07
Compare
Skrilltrax
reviewed
Dec 29, 2021
app/src/main/java/dev/msfjarvis/aps/util/auth/BiometricAuthenticator.kt
Outdated
Show resolved
Hide resolved
msfjarvis
removed
the
S-waiting-on-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Refactors
BiometricAuthenticatorto explicitly handle all error codes fromBiometricPrompt, adds an explicitRetrytype toBiometricAuthenticator.Result, and downgrades authentication failures toRetryrather thanFailed.Fixes #1626
💡 Motivation and Context
A failure in biometric authentication is not an irrecoverable state so treating it as one has the potential to create confusing UX, such as in #1626 where the prompt is closed when an incorrect fingerprint is used.
💚 How did you test it?
Verified incorrect fingerprints do not cause the authentication prompt to get dismissed immediately
📝 Checklist
./gradlew spotlessApply