This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Support pasting username with autofill, fixes #192 #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeapo
reviewed
Jul 25, 2017
| public static final String TAG = "Keychain"; | ||
| final class Constants { | ||
| static final String TAG = "Keychain"; | ||
| static final long MAX_PASSWORD_ENTRY_LIFETIME = 45 * 1000; |
Contributor
There was a problem hiding this comment.
We could use the same timeout value as the copy/paste
Contributor
There was a problem hiding this comment.
It's general_show_time, we should rename it as it's used for visibility and clipboard timeouts.
Contributor
|
Thanks for the PR. In the workflow, could you add a notification (snack or toast, chose what you think is better) to inform the user that the selected password has a username in it and that the password was put in cache for |
Contributor
Author
|
I added the toast in a 2nd commit for easier review. Feel free to squash the commits when merging. |
Contributor
|
Works perfectly, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow for pasting usernames is as follows: