This repository was archived by the owner on Oct 15, 2024. It is now read-only.
BaseGitActivity: don't remove saved password unnecessarily #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if previousUrl is empty it means that this the first time the method is being called, and url has not been built yet. We let things slide for the first pass so that the actual logic only kicks in when it needs to. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
fmeum
approved these changes
Apr 21, 2020
Member
fmeum
left a comment
fmeum
left a comment
There was a problem hiding this comment.
I was just about to bring this up as a potential root cause to look into. Glad you found and fixed it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Don't clear
https_passwordwhenupdateUrlis called for the first time. Fixed #725.💡 Motivation and Context
when
updateUrlis first called, it tries to fillpreviousUrlwith the class variableurlbut sinceurlis going to be initialized later in this method,previousUrlisleft empty. This has the unfortunate side affect that our logic to remove saved HTTPS
password on hostname change is always triggered in this first pass of
updateUrl, resultingin users always being prompted for their password.
💚 How did you test it?
Manually verify HTTPS password is correctly persisted on future invocations of
GitOperation.📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
R E L E A S E📸 Screenshots / GIFs