Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Conversation

@msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Jun 12, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Updates the android-emulation-runner action to v2.10.0 to support API 30 as a emulator target.

💡 Motivation and Context

While I do use APS on Android R it's helpful to be able to also verify that with our test suite, which hopefully continues expanding in the future.

💚 How did you test it?

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

Moar tests!

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the 1.9.0 milestone Jun 12, 2020
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Copy link
Member Author

API 30 only has a google_apis variant available at the moment so we'll need to turn it on for everybody.

@msfjarvis msfjarvis merged commit bf33fb2 into android-password-store:master Jun 12, 2020
@msfjarvis msfjarvis deleted the refactor/test-api-30 branch June 12, 2020 10:55
msfjarvis added a commit that referenced this pull request Jun 23, 2020
* Revert "github: run instrumentation tests against API 30 (#847)"

API 30 is too flaky to be a part of our active test suite.

This reverts commit bf33fb2.

* github: bump android-emulator-runner action

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants