This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Improve UI when launching with biometric lock #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
They're included by manifest-merger from androidx.biometric Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
fmeum
previously approved these changes
Jul 19, 2020
Skrilltrax
previously approved these changes
Jul 19, 2020
Member
|
Cool, btw I'm trying to rework auth the way andOTP does because using ProcessLifecycleManager and onBackground breaks auth due to OOS's full-screen BiometricPrompt implementation. |
* develop: Remove type images (#939) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Skrilltrax
approved these changes
Jul 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Use a transparent activity for authentication dialog, and remove the fade transition.
💡 Motivation and Context
This greatly improves the UX for me and the users I dogfooded this with.
💚 How did you test it?
Manually
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs
Before
After