-
Notifications
You must be signed in to change notification settings - Fork 224
Enable dependency signature verification #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ensure that all the dependencies used are signed with expected keys. Followed https://developer.android.com/build/dependency-verification Test: ./gradlew build --dry-run
Summary of ChangesHello @liutikas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's supply chain security by implementing Gradle's dependency verification. It ensures that all third-party libraries are either signed by trusted PGP keys or have their integrity validated through recorded SHA256 checksums, thereby mitigating risks associated with compromised dependencies. This change establishes a robust mechanism for verifying the provenance and integrity of external code. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great step towards improving the project's supply chain security by enabling Gradle's dependency verification. The configuration correctly disables remote key servers and pins checksums for unsigned artifacts. I've found a few areas for improvement:
- There are some highly suspicious entries for Guava dependencies that need to be investigated as they could indicate a serious security risk.
- The trust granted to some PGP keys is overly broad, which could be tightened to improve security.
- A minor cleanup for the key server configuration.
Please see my detailed comments.
Ensure that all the dependencies used are signed with expected keys.
Followed https://developer.android.com/build/dependency-verification
Test: ./gradlew build --dry-run
Fixes #175