-
Notifications
You must be signed in to change notification settings - Fork 235
Update Deps + Remove screenshot testing plugin until it works with newer versions of Gradle plugin #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f Gradle plugin. Update Compose + other dependencies to 1.10 etc
Summary of ChangesHello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade, bringing the project up to date with newer versions of the Android Gradle Plugin and several core Compose libraries. A key part of this update involves the temporary removal of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies, including the Android Gradle Plugin, Compose, and CameraX, and also removes the screenshot testing plugin due to compatibility issues with newer Gradle versions. The Kotlin code refactoring in Motion.kt and SharedElementsConfig.kt to use SAM conversions is a good improvement for code conciseness.
My review focuses on the dependency updates in gradle/libs.versions.toml. I've identified a critical version mismatch with KSP that will likely break the build, and an inconsistency in how Compose dependencies are versioned which could lead to runtime issues. Please see the detailed comments.
Update Compose + other dependencies to 1.10 too.