Skip to content

Fix lint warnings [master] #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix lint warnings [master] #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import android.widget.Toast
import com.example.android.codelabs.paging.R
import com.example.android.codelabs.paging.Injection
import com.example.android.codelabs.paging.model.Repo
import kotlinx.android.synthetic.clearFindViewByIdCache
import kotlinx.android.synthetic.main.activity_search_repositories.*


Expand Down Expand Up @@ -58,6 +59,11 @@ class SearchRepositoriesActivity : AppCompatActivity() {
initSearch(query)
}

override fun onDestroy() {
super.onDestroy()
clearFindViewByIdCache()
}

override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
outState.putString(LAST_SEARCH_QUERY, viewModel.lastQueryValue())
Expand All @@ -78,22 +84,22 @@ class SearchRepositoriesActivity : AppCompatActivity() {
private fun initSearch(query: String) {
search_repo.setText(query)

search_repo.setOnEditorActionListener({ _, actionId, _ ->
search_repo.setOnEditorActionListener { _, actionId, _ ->
if (actionId == EditorInfo.IME_ACTION_GO) {
updateRepoListFromInput()
true
} else {
false
}
})
search_repo.setOnKeyListener({ _, keyCode, event ->
}
search_repo.setOnKeyListener { _, keyCode, event ->
if (event.action == KeyEvent.ACTION_DOWN && keyCode == KeyEvent.KEYCODE_ENTER) {
updateRepoListFromInput()
true
} else {
false
}
})
}
}

private fun updateRepoListFromInput() {
Expand Down