Migrating to Paging 3.0 #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
force-pushed
the
fm/network_paging
branch
2 times, most recently
from
4be5340 to
7a01b04
Compare
manuelvicnt
reviewed
Feb 26, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
Outdated
Show resolved
Hide resolved
manuelvicnt
reviewed
Feb 26, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesActivity.kt
Outdated
Show resolved
Hide resolved
manuelvicnt
reviewed
Feb 26, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
ChrisCraik
reviewed
Feb 27, 2020
app/src/main/java/com/example/android/codelabs/paging/data/GithubPagingSource.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubPagingSource.kt
Outdated
Show resolved
Hide resolved
| ) : PagingSource<Int, Repo>() { | ||
| override suspend fun load(params: LoadParams<Int>): LoadResult<Int, Repo> { | ||
| val position = params.key ?: 0 | ||
| val apiResponse = searchRepos(service, query, position, GithubRepository.NETWORK_PAGE_SIZE) |
There was a problem hiding this comment.
should sync with Dustin in the PagingWithNetworkSample to standardize as to whether we want to use suspend Response retrofit APIs, or the Response-less ones. I'm fine either way, but there is some value in consistency.
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/data/GithubRepository.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
07c9ed6 to
ce10dce
Compare
florina-muntenescu
force-pushed
the
fm/start_network_flow
branch
from
a46568b to
0e2044f
Compare
florina-muntenescu
force-pushed
the
fm/network_paging
branch
4 times, most recently
from
fcc0bae to
781b2a9
Compare
ChrisCraik
reviewed
Mar 5, 2020
ChrisCraik
left a comment
ChrisCraik
left a comment
There was a problem hiding this comment.
Couple things I found while copying code into KDoc samples
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
ChrisCraik
reviewed
Mar 6, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
8ea1b7a to
b8eae01
Compare
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
b8eae01 to
d5711cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role of this PR is just to showcase the differences between the starting point of the codelab and the final one, with paging added.