Adding separators to list of repositories #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
from
1e54226 to
bc3ef1f
Compare
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
ce10dce to
e395f8e
Compare
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
2 times, most recently
from
c72c7b1 to
a4fee40
Compare
florina-muntenescu
force-pushed
the
fm/network_paging
branch
2 times, most recently
from
bde42c7 to
fcc0bae
Compare
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
fcc0bae to
781b2a9
Compare
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
3 times, most recently
from
98c2f41 to
8115111
Compare
ChrisCraik
reviewed
Mar 6, 2020
| lastQueryValue = queryString | ||
| val newResult = repository.getSearchResultStream(queryString) | ||
| val newResult: Flow<PagingData<UiModel>> = repository.getSearchResultStream(queryString) | ||
| .map { pagingData -> pagingData.map { UiModel.RepoItem(it) as UiModel } } |
There was a problem hiding this comment.
if you skip this map, then the subsequent map shouldnt ahve to do the is checks - they'll always be true
There was a problem hiding this comment.
Disregard this and the below comment for now!
Realized this is a bug in the generics of this function that prevents you from doing this more cleanly: https://issuetracker.google.com/issues/151050495
| override fun areItemsTheSame(oldItem: Repo, newItem: Repo): Boolean = | ||
| oldItem.fullName == newItem.fullName | ||
| private val UIMODEL_COMPARATOR = object : DiffUtil.ItemCallback<UiModel>() { | ||
| override fun areItemsTheSame(oldItem: UiModel, newItem: UiModel): Boolean { |
There was a problem hiding this comment.
this will make separators always crossfade, this should check for SeparatorItem too.
| val newResult: Flow<PagingData<UiModel>> = repository.getSearchResultStream(queryString) | ||
| .map { pagingData -> pagingData.map { UiModel.RepoItem(it) as UiModel } } | ||
| .map { | ||
| it.insertSeparators { before, after -> |
There was a problem hiding this comment.
without the above map, before/after will be RepoItems, so you don't need to do all the checks
you may end up needing to be specific about generics, but I think that's clearer than adding all the uses of 'is' as 'as'
florina-muntenescu
force-pushed
the
fm/network_paging
branch
from
b8eae01 to
d5711cc
Compare
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
from
8115111 to
a5be06e
Compare
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
from
a5be06e to
8e1f374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.