Adding header showing total number of repos #43
Conversation
| if (response.isSuccessful) { | ||
| val repos = response.body()?.items ?: emptyList() | ||
| return RepoSearchResult.Success(repos) | ||
| return RepoSearchResult.Success(repos, response.body()?.total ?: 0) |
There was a problem hiding this comment.
What does it look like if you just return the response object directly from the GithubService?
I think removing the RepoSearchResult wrapper may make it easier for folks to see retrofit <-> paging connection all in one place, and copy the code out.
There was a problem hiding this comment.
If this is only used in PagingSource then, it should be ok. I just don't want to Retrofit Response to leak in Repository.
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
4 times, most recently
from
98c2f41 to
8115111
Compare
florina-muntenescu
force-pushed
the
fm/paging_separators
branch
2 times, most recently
from
a5be06e to
8e1f374
Compare
|
Hi, @florina-muntenescu, sorry to bother you. I don't know why this PR is closed but I'm trying to replicate what you did here, displaying the total number of items returned from GitHub Search API. But the problem is that the Would you be able to help me fix this? |
3 participants
No description provided.