Step 2 - Migrate to Paging 3.0 #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisCraik
reviewed
Mar 14, 2020
app/src/main/java/com/example/android/codelabs/paging/data/GithubPagingSource.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| adapter.addLoadStateListener { loadType, loadState -> | ||
| Log.d("SearchRepositoriesActivity", "adapter load: type = $loadType state = $loadState") | ||
| if (loadType == LoadType.REFRESH) { |
There was a problem hiding this comment.
I think it may be clearer if you put the entire body of this behind a "LoadType == Refresh" check.
That also makes the Toast only happen when it's a refresh error, instead of all
Collaborator
Author
There was a problem hiding this comment.
I actually wanted to happen always.
In the initial code, whenever there is an error we show the toast.
florina-muntenescu
force-pushed
the
step1_mergeadapter
branch
2 times, most recently
from
96f10ce to
740b32c
Compare
florina-muntenescu
force-pushed
the
step2_paging3.0
branch
from
4bedb47 to
e018324
Compare
florina-muntenescu
force-pushed
the
step1_mergeadapter
branch
from
cfe2e49 to
78ec14e
Compare
…button for new queries
…oving unnecessary code from ReposAdapter
florina-muntenescu
force-pushed
the
step2_paging3.0
branch
from
dd95eec to
93a42bf
Compare
dlam
reviewed
Mar 31, 2020
| } else { | ||
| binding.emptyList.visibility = View.GONE | ||
| binding.list.visibility = View.VISIBLE | ||
| private fun search(query: String) { |
Collaborator
There was a problem hiding this comment.
Would be nice if we could represent this as a Flow<String> and then we could just do collectLatest / mapLatest on it !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.