Step 3 - Add separators every 10k stars #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
force-pushed
the
step3_separators
branch
from
6e2e501 to
cb7e88c
Compare
florina-muntenescu
changed the title
florina-muntenescu
force-pushed
the
step3_separators
branch
from
cb7e88c to
9f4b68a
Compare
dlam
reviewed
Mar 13, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/ReposAdapter.kt
Outdated
Show resolved
Hide resolved
ChrisCraik
reviewed
Mar 14, 2020
| override fun areItemsTheSame(oldItem: Repo, newItem: Repo): Boolean { | ||
| return if (oldItem is Repo && newItem is Repo) { | ||
| oldItem == newItem | ||
| private val UIMODEL_COMPARATOR = object : DiffUtil.ItemCallback<UiModel>() { |
There was a problem hiding this comment.
The code as written will cause all separators to shimmer, it should be checking for separators too
Should be fine to say all separators are the same, since DiffUtil will be doing greedy matching
I don't think any of this matters in behavior here, since without swipe to refresh, you're not actually going to see any diffing 🤷♂️ but still good to recommend correct code in case they do
Collaborator
Author
There was a problem hiding this comment.
added separator as well
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
dlam
reviewed
Mar 14, 2020
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/android/codelabs/paging/ui/SearchRepositoriesViewModel.kt
Outdated
Show resolved
Hide resolved
florina-muntenescu
force-pushed
the
step2_paging3.0
branch
from
4bedb47 to
e018324
Compare
florina-muntenescu
force-pushed
the
step3_separators
branch
2 times, most recently
from
7ad2afc to
13e22e5
Compare
florina-muntenescu
force-pushed
the
step2_paging3.0
branch
from
dd95eec to
93a42bf
Compare
* Simplifying insertSeparators * Simplifying ReposAdapter
florina-muntenescu
force-pushed
the
step3_separators
branch
from
312c28c to
fd66251
Compare
Fix for separator logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.