Fix RemoteMediator implementation #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florina-muntenescu
force-pushed
the
step4/database
branch
2 times, most recently
from
1265543 to
cca3f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need to wait for this fix to land: https://android-review.googlesource.com/c/platform/frameworks/support/+/1285582
Btw: withTransaction already dispatches on the room threadpool, so no need for Dispatchers.IO
I might have incorrectly given you this check last time:
state.pages.lastOrNull { it.data.isNotEmpty() }, as it filters out the last page which has the nextKey correctly set to null. This was causing an infinite-loop of using the second last page's next key to invalidate and load the empty last page over and over again