Apply code cleanups from step13 #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlam
commented
Jun 30, 2020
|
|
||
| import androidx.lifecycle.* | ||
| import androidx.lifecycle.ViewModel | ||
| import androidx.lifecycle.viewModelScope |
Collaborator
Author
There was a problem hiding this comment.
autoimport from -ktx i think?
florina-muntenescu
force-pushed
the
step11_loading_state
branch
from
216cb26 to
e4086ce
Compare
Collaborator
|
🤦♀️ Looks like I didn't push step11 when rebasing but i had pushed all the other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially needs to get applied to step 12 too?