return success with endOfPaginationReached set to true when nextkey is null

[sanghoon9173]

Should we return success with endOfPaginationReached set to true if nextKey is null for Append LoadType?

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[sanghoon9173]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[sanghoon9173]

Also, one question:
Let's say we cached everything from remote (nextKey for the last item in the last page is null). At this point there is more repos added to the server. However, the client thinks that it has already fetched everything, and therefore it won't try get the newly added repos. How would we handle this case?

[dlam]

We should never get into this situation when fetching the remote nextKey from DB as the page that would've written null for nextKey in RemoteKey DB already returns endOfPaginationReached = true for MediatorResult, so we never expect to get another APPEND load in RemoteMediator after that.

Also, one question:
Let's say we cached everything from remote (nextKey for the last item in the last page is null). At this point there is more repos added to the server. However, the client thinks that it has already fetched everything, and therefore it won't try get the newly added repos. How would we handle this case?

If you have an external signal for data staleness or new data, you can simply insert the new data into DB and let PagingSource invalidation propagate REFRESH for you. In case the logic for receiving / fetching those items is the same as RemoteMediator implementation and you want to avoid duplicating logic already in RemoteMediator, you can also just call adapter.refresh() manually.

[florina-muntenescu]

Logic here was changed meanwhile