Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Commit dec4399

Browse files
committed
Simplified oscillator creation
2 parents dece4dd + 6ed1404 commit dec4399

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

app/src/main/cpp/AudioEngine.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,13 @@ void errorCallback(AAudioStream *stream,
3838
}
3939
}
4040

41-
AudioEngine::AudioEngine() {
42-
oscillator_ = new Oscillator();
43-
}
44-
4541
bool AudioEngine::start() {
4642
AAudioStreamBuilder *streamBuilder;
4743
AAudio_createStreamBuilder(&streamBuilder);
4844
AAudioStreamBuilder_setFormat(streamBuilder, AAUDIO_FORMAT_PCM_FLOAT);
4945
AAudioStreamBuilder_setChannelCount(streamBuilder, 1);
5046
AAudioStreamBuilder_setPerformanceMode(streamBuilder, AAUDIO_PERFORMANCE_MODE_LOW_LATENCY);
51-
AAudioStreamBuilder_setDataCallback(streamBuilder, ::dataCallback, oscillator_);
47+
AAudioStreamBuilder_setDataCallback(streamBuilder, ::dataCallback, &oscillator_);
5248
AAudioStreamBuilder_setErrorCallback(streamBuilder, ::errorCallback, this);
5349

5450
// Opens the stream.
@@ -61,7 +57,7 @@ bool AudioEngine::start() {
6157

6258
// Retrieves the sample rate of the stream for our oscillator.
6359
int32_t sampleRate = AAudioStream_getSampleRate(stream_);
64-
oscillator_->setSampleRate(sampleRate);
60+
oscillator_.setSampleRate(sampleRate);
6561

6662
// Starts the stream.
6763
result = AAudioStream_requestStart(stream_);
@@ -93,5 +89,5 @@ void AudioEngine::restart(){
9389
}
9490

9591
void AudioEngine::setToneOn(bool isToneOn) {
96-
oscillator_->setWaveOn(isToneOn);
92+
oscillator_.setWaveOn(isToneOn);
9793
}

app/src/main/cpp/AudioEngine.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
class AudioEngine {
2424
public:
25-
AudioEngine();
26-
2725
bool start();
2826

2927
void stop();
@@ -33,7 +31,7 @@ class AudioEngine {
3331
void setToneOn(bool isToneOn);
3432

3533
private:
36-
Oscillator *oscillator_;
34+
Oscillator oscillator_;
3735
AAudioStream *stream_;
3836
};
3937

0 commit comments

Comments
 (0)