Skip to content

[jetcaster] Fixed the laggy scrolling #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2021
Merged

[jetcaster] Fixed the laggy scrolling #614

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e75adba
Fixed the laggy scrolling
kedar1607 Jul 26, 2021
abbda5f
Addressed review comments.
kedar1607 Jul 26, 2021
29cdee1
Remove extra spaces
kedar1607 Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package com.example.jetcaster.ui.home.category
import androidx.compose.foundation.Image
import androidx.compose.foundation.clickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
Expand Down Expand Up @@ -67,6 +68,7 @@ import androidx.lifecycle.viewmodel.compose.viewModel
import coil.compose.rememberImagePainter
import com.example.jetcaster.R
import com.example.jetcaster.data.Episode
import com.example.jetcaster.data.EpisodeToPodcast
import com.example.jetcaster.data.Podcast
import com.example.jetcaster.data.PodcastWithExtraInfo
import com.example.jetcaster.ui.home.PreviewEpisodes
Expand Down Expand Up @@ -98,20 +100,39 @@ fun PodcastCategory(
/**
* TODO: reset scroll position when category changes
*/
LazyColumn(
modifier = modifier,
Column(modifier = modifier) {
CategoryPodcasts(viewState.topPodcasts, viewModel)
EpisodeList(viewState.episodes)
}
}

@Composable
private fun CategoryPodcasts(
topPodcasts: List<PodcastWithExtraInfo>,
viewModel: PodcastCategoryViewModel
) {
LazyRow(
contentPadding = PaddingValues(0.dp),
horizontalAlignment = Alignment.Start
horizontalArrangement = Arrangement.Start
) {
item {
CategoryPodcastRow(
podcasts = viewState.topPodcasts,
podcasts = topPodcasts,
onTogglePodcastFollowed = viewModel::onTogglePodcastFollowed,
modifier = Modifier.fillParentMaxWidth()
)
}
}
}

@Composable
private fun EpisodeList(episodes: List<EpisodeToPodcast>) {
LazyColumn(
contentPadding = PaddingValues(0.dp),
verticalArrangement = Arrangement.Center
) {

items(viewState.episodes, key = { it.episode.uri }) { item ->
items(episodes, key = { it.episode.uri }) { item ->
EpisodeListItem(
episode = item.episode,
podcast = item.podcast,
Expand Down