-
Notifications
You must be signed in to change notification settings - Fork 644
Add Dolby Vision Profile 10 Playback Support #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ybai001
wants to merge
2
commits into
androidx:main
Choose a base branch
from
DolbyLaboratories:dlb/dv-profile10/dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it means this is a DV profile 10.0 content, which is not backward compatible to AV1 so that it cannot be played as AV1 content on non-Dolby licensed device.
Instead, DV profile 10.1 and 10.4 can be played as AV1 content on non-Dolby licensed device.
See more details on https://professionalsupport.dolby.com/s/article/What-is-Dolby-Vision-Profile?language=en_US, table 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ybai001
Do DV profiles 10.1 and 10.4 not have these color space values? Or your solution is to only set these values for 10.0 and using that fact to make sure its not backwards compatible?
If other DV profiles have these color space values then its not a robust solution. What if in the future that information is generally parsed for all DolbyVision streams for some other purpose? Is there any other way to know the cross-compatibility id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@microkatz, we actually set these values for other profiles here.
Let me provide more info about this code change.
Dolby Vision profile 10 includes profile 10.0, 10.1 and 10.4 currently. P10.0 is not backward-compatible with AV1 and cannot be played on non-Dolby licensed device while P10.1 and P10.4 can. The purpose of this piece of code is to return null for P10.0 and to return MimeTypes.VIDEO_AV1 for P10.1 and 10.4.
This method (getAlternativeCodecMimeType()) is called in both track selection and codec selection phase.
During track selection phase, the input is manifest file. CCID is not explicitly indicated in manifest file. The only method is to calculate it based on supplementalCodecs and supplementalProfiles (Since neither supplementalCodecs nor supplementalProfiles is the member of Format structure, we set ColorInfo at first then conclude the CCID based on it).
During codec selection phase, the input includes MPEG4 box info. CCID can be get directly by parsing Format::initializationData.
As a common method in both track selection and codec selection phase, we adopted the ColorInfo method in this PR.
I agree it is not a perfect solution. In future, maybe we need to update getColorInfoForFormat() method to adapt new Dolby Vision profile definitions.