Add handling for single queries with semicolon #8
Conversation
main.py
Outdated
| load_dotenv() # only on local run | ||
| print(os.environ) | ||
| queries_list = os.environ['INPUT_QUERIES'].split(';') | ||
| queries_list = map(str.strip, os.environ['INPUT_QUERIES'].split(';')) |
There was a problem hiding this comment.
Just for safety to get rid of unnecessary whitespace
main.py
Outdated
| if query: | ||
| query_result = con.query(query) | ||
| query_results.append(query_result) | ||
| print("### Running query ###") | ||
| print(f"[!] Query id - {query_result.query_id}") | ||
| print(f"[!] Running query ### - {query}") |
There was a problem hiding this comment.
Perhaps just filter out any None or empty query from queries_list instead of duplicating this if twice?
There was a problem hiding this comment.
So you'd find it cleaner if we used filter when generating the queries_list?
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
@dluftspring sorry to let you down, but we're not maintaining this one anymore since we're not at @anecdotes-ai anymore. You'll need someone from the team to review it -- I'll try to ping someone |
3 participants
Description
👋 Just throwing this up here for review as I think I ran into a single query error using this action. My read is that when you pass a single query trying to split on the
;causes an empty string to be sent to snowflake which then throws an error on the action. If you'd prefer to just document this behaviour as opposed to introducing new code that makes sense but I thought I would propose these changes as a suggestion