feat: aggregate hotspots

Author: manfredsteyer

backend/src/index.ts

@@ -12,7 +12,7 @@ import { calcModuleInfo } from "./services/module-info";
 import { calcTeamAlignment } from "./services/team-alignment";
 import { openSync } from './utils/open';
 import { ensureConfig } from "./infrastructure/config";
-import { findHotspotFiles, HotspotCriteria } from "./services/hotspot";
+import { aggregateHotspots, findHotspotFiles, HotspotCriteria } from "./services/hotspot";
 
 const options = parseOptions(process.argv.slice(2));
 
@@ -93,11 +93,27 @@ app.get("/api/team-alignment", async (req, res) => {
   }
 });
 
+app.get("/api/hotspots/aggregated", async (req, res) => {
+  const minScore = Number(req.query.minScore) || -1;
+  const criteria = { minScore, module: '' };
+
+  try {
+    const result = await aggregateHotspots(criteria, options);
+    res.json(result);
+  } catch (e) {
+    console.log('error', e);
+    res.status(500).json(e);
+  }
+});
+
 app.get("/api/hotspots", async (req, res) => {
   const minScore = Number(req.query.minScore) || -1;
+  const module = req.query.module ? String(req.query.module) : '';
+
+  const criteria = { minScore, module };
 
   try {
-    const result = await findHotspotFiles({minScore: minScore}, options);
+    const result = await findHotspotFiles(criteria, options);
     res.json(result);
   } catch (e) {
     console.log('error', e);

backend/src/services/hotspot.ts

@@ -3,6 +3,7 @@ import { Options } from "../options/options";
 import { parseGitLog } from "../utils/git-parser";
 import * as fs from 'fs';
 import { calcComplexity } from "../utils/complexity";
+import { loadConfig } from "../infrastructure/config";
 
 export type Hotspot = {
   commits: number,
@@ -28,11 +29,21 @@ export type HotspotCriteria = {
   // minCommits: number;
   // minChangedLines: number;
   // minComplexity: number;
+  module: string,
   minScore: number,
 };
 
+export type AggregatedHotspot = {
+  module: string;
+  count: number;
+}
+
+export type AggregatedHotspotsResult = {
+  aggregated: AggregatedHotspot[];
+}
+
 export async function findHotspotFiles(criteria: HotspotCriteria, options: Options): Promise<HotspotResult> {
-  const hotspots: Record<string, Hotspot> = await _findHotspots(options);
+  const hotspots: Record<string, Hotspot> = await _findHotspots(criteria, options);
 
   const filtered: FlatHotspot[] = []; 
   for (const fileName of Object.keys(hotspots)) {
@@ -43,26 +54,44 @@ export async function findHotspotFiles(criteria: HotspotCriteria, options: Optio
     }
   }
 
+  filtered.sort((a, b) => a.score - b.score);
+
   return { hotspots: filtered };
 }
 
-// export async function aggregateHotspots(criteria: HotspotCriteria, options: Options): Promise<HotspotResult> {
-//   const hotspots: Record<string, Hotspot> = await _findHotspots(options);
+export async function aggregateHotspots(criteria: HotspotCriteria, options: Options): Promise<AggregatedHotspotsResult> {
+  const hotspots = (await findHotspotFiles(criteria, options)).hotspots;
+  const config = loadConfig(options);
 
-//   const config = loadConfig();
+  const result: AggregatedHotspot[] = []; 
+  for (const module of config.scopes) {
+    let count = 0;
+    for (const hotspot of hotspots) {
+      if (hotspot.fileName.startsWith(module) && hotspot.score >= criteria.minScore) {
+        count++;
+      }
+    }
+    result.push({ module, count });
+  }
 
-//   return { hotspots: filtered };
-// }
+  result.sort((a, b) => a.count - b.count);
+  return { aggregated: result };
+}
 
-async function _findHotspots(options: Options) {
+async function _findHotspots(criteria: HotspotCriteria, options: Options) {
   const hotspots: Record<string, Hotspot> = {};
 
   await parseGitLog((entry) => {
     for (const change of entry.body) {
       let hotspot: Hotspot;
+
+      if (!change.path.startsWith(criteria.module)) {
+        continue;
+      }
+
       if (!hotspots[change.path]) {
 
-        let cc = -1;
+        let cc = 1;
         const filePath = path.join(options.path, change.path);
         if (filePath.endsWith('.ts') && fs.existsSync(filePath)) {
           cc = calcComplexity(filePath);
@@ -71,7 +100,7 @@ async function _findHotspots(options: Options) {
         hotspot = {
           commits: 0,
           changedLines: 0,
-          complexity: -1,
+          complexity: cc,
           score: 0,
         };