fix: normalize path for hotspot analysis

Author: manfredsteyer

apps/backend/src/infrastructure/config.ts

@@ -11,7 +11,7 @@ const initConfig: Config = {
   entries: [],
   filter: {
     files: [],
-    logs: []
+    logs: [],
   },
   teams: {
     'example-team-a': ['John Doe', 'Jane Doe'],

apps/backend/src/model/config.ts

@@ -6,7 +6,7 @@ export type Filter = {
 export type Config = {
   scopes: string[];
   groups: string[];
-  filter: Filter,
+  filter: Filter;
   teams: Record<string, string[]>;
   entries: [];
 };
@@ -18,6 +18,6 @@ export const emptyConfig: Config = {
   entries: [],
   filter: {
     logs: [],
-    files: []
-  }
+    files: [],
+  },
 };

apps/backend/src/services/hotspot.ts

@@ -92,8 +92,8 @@ export async function aggregateHotspots(
     let count = 0;
     for (const hotspot of hotspots) {
       if (
-        hotspot.fileName.startsWith(module) &&
-        hotspot.score >= criteria.minScore
+        hotspot.fileName.startsWith(module)
+        //&& hotspot.score >= criteria.minScore
       ) {
         count++;
       }
@@ -118,11 +118,13 @@ async function analyzeLogs(
     filter,
   };
 
+  const module = criteria.module ? normalizeFolder(criteria.module) : '';
+
   await parseGitLog((entry) => {
     for (const change of entry.body) {
       let hotspot: Hotspot;
 
-      if (!change.path.startsWith(criteria.module)) {
+      if (!change.path.startsWith(module)) {
         continue;
       }
 

apps/backend/src/utils/git-parser.spec.ts

@@ -261,10 +261,7 @@ describe('git parser', () => {
           limitMonths: 0,
         },
         filter: {
-          logs: [
-            'does not match',
-            'format with prettier'
-          ],
+          logs: ['does not match', 'format with prettier'],
         },
       };
 
@@ -577,15 +574,14 @@ describe('git parser', () => {
       ]);
     });
 
-
     it('filters files', async () => {
       const parseOptions: ParseOptions = {
         limits: {
           limitCommits: 2,
           limitMonths: 0,
         },
         filter: {
-          files: ['**/*.ts', '!**/*.spec.ts']
+          files: ['**/*.ts', '!**/*.spec.ts'],
         },
       };
 
@@ -594,7 +590,6 @@ describe('git parser', () => {
       parseGitLog((entry) => {
         entries.push(entry);
       }, parseOptions);
-
     });
-  })
+  });
 });

apps/backend/src/utils/git-parser.ts

@@ -34,23 +34,25 @@ const initHeader: LogHeader = {
 
 export type ParseOptions = {
   limits: Limits;
-  filter?: Filter
+  filter?: Filter;
 };
 
 export const defaultParseOptions: ParseOptions = {
   limits: noLimits,
   filter: {
     files: [],
-    logs: []
-  }
+    logs: [],
+  },
 };
 
 export async function parseGitLog(
   callback: ParserCallback,
   options = defaultParseOptions
 ) {
   const limits = options.limits;
-  const fileFilter = (options.filter?.files?.length) ? options.filter.files : ['**/*.ts'];
+  const fileFilter = options.filter?.files?.length
+    ? options.filter.files
+    : ['**/*.ts'];
 
   let pos = 0;
   const log = loadCachedLog();